search

siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.39k stars 514 forks source link

Prompt if reboot is required when apply affect may need one. #6394

Open Jackbennett opened 1 year ago

Jackbennett commented 1 year ago

Feature Request

Updated machine registry config requires a reboot, but the cli does not warn you;

> talosctl apply -f controlplane.yaml
Applied configuration without a reboot

Kind of implies to me there's a check if a reboot might be required on apply.

Description

Within the manual;

.machine.registries (CRI containerd plugin will not pick up the registry authentication settings without a reboot) https://www.talos.dev/v1.2/talos-guides/configuration/editing-machine-configuration/

So upon applying that change the CLI could know it won't take effect until reboot. I think not automatically rolling out reboots is the correct behaviour.

smira commented 1 year ago

It's complicated, as images are pulled by Talos and CRI.

Talos applies any changes on the fly.

CRI applies some changes on the fly, and some not. CRI should be fixed eventually to support reloading everything on the fly, but it's not something we have control over.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Jackbennett commented 2 months ago

It's not stale but unresolved. Making the cri dynamic works sure be cool but I think this issue is more about the manual knows a key needs a reboot so the cli could let me know ones needed. Or if not at apply time some reconcile earning, like you get if I use mismatched talosctl versions