siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.39k stars 514 forks source link

Talos upgrade to optionally store log to Ephemeral partition #7364

Open salkin opened 1 year ago

salkin commented 1 year ago

Feature Request

Make an optional parameter to talosctl upgrade to store log of the upgrade boot cycle to Ephemeral partition "/var/log/" or user definable for the upgrade procedure.

Description

When performing upgrades of Talos at some environments BMC console log is not necessarily always available, if the upgrade fails to pull upgrade image or otherwise failing it's difficult to guess what is wrong in the environment without the console log from the upgrade cycle.

smira commented 1 year ago

talosctl upgrade --debug should provide that information though?

salkin commented 1 year ago

To clarify more. With single node k8s clusters the upgrades have to be done via staged mode as giving upgrade without staged mode in single node is not really working stable.

Therefore the logs would need to be collected from the staged boot and stored somewhere so that they can be looked on if the staged upgrade failed.

Upgrade is done by the node itself via gRPC API and therefore the --debug option cannot be used as the node itself if rebooting due to the staged mode.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.