search

siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.78k stars 542 forks source link

Preserve more kernel parameters upon install/upgrade #9124

Open mattiascockburn opened 2 months ago

mattiascockburn commented 2 months ago

Feature Request

Description

Currently a specific set of kernel parameters is preserved during install/upgrade no matter what: https://github.com/siderolabs/talos/blob/9b9159d1e04d337dc3a51e41be57f4795e71255d/internal/pkg/install/install.go#L180

One common way a user might also customize the running system is through the use of talos.environment parameters (settings like http(s)_proxy, no_proxy and the like). Would it be possible to include these parameters in the list of preserved parameters as well?

I know that the could also be set in a machineconfig, but this needs to be done separately.

smira commented 2 months ago

We would rather not make more kernel args to be preserved, and move towards machine configuration (multi-document) which will be available in any machine state (running Kubernetes or wiped).