UX: warn if using talosctl less than server version

siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.

https://www.talos.dev

Mozilla Public License 2.0

6.96k stars 565 forks source link

UX: warn if using talosctl less than server version #9474

Open steverfrancis opened 1 month ago

steverfrancis commented 1 month ago

This seems worth having talosctl issue a warning about:

Maybe it's worth breaking the talosctl invocation when server [major.minor] version > talosctl [major.minor] version ? Such invocation is most times incorrect or even dangerous.

Originally posted by @vladimirfx in https://github.com/siderolabs/talos/issues/9469#issuecomment-2399553507

vladimirfx commented 1 month ago

The original idea was to stop some operations if the server (machined) is a higher version than the client (talosctl). That is because such operations can damage installation in the worst case. Proposed operations:

apply-config
etcd
inject
machineconfig
meta
reset
upgrade
upgrade-k8s

And other modifying machine config and k8s config.

smira commented 1 month ago

If you have examples of damaging the Talos install, it'd be interesting to see. So far it's more of a UX issue that the command fails until it is in sync with Talos version.