siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.91k stars 556 forks source link

Light color theme making it impossible to read the text without highlighting it in iTerm2. #9490

Open Biodiscus opened 1 month ago

Biodiscus commented 1 month ago

Bug Report

The way the colors are handled within Talos are preventing me from using a lighter theme while using talosctl dashboard.

Description

I've forked the repo and made a fix for myself here, which uses the terminal colors instead. The reason why I have made it a fork for the time being, is because the colors become less vibrant in darker terminals so it's not the perfect solution but works for me :)

When I'm using a lighter color scheme on iTerm2 the dashboard looks like:

image

and I can only look at the content when I select the whole text:

image

With my fork it looks like:

image

and the monitor page looks like:

image

The downside being that the colors looks more "faded" when using a darker theme:

image

compared to the current dashboard:

image

However, the "faded" one does honor the more darker white color of the scheme itself.

Logs

None

Environment

Client:
    Tag:         v1.8.0
    SHA:         5cc935f7
    Built:
    Go version:  go1.22.7
    OS/Arch:     darwin/arm64
Server:
    NODE:        192.168.2.110
    Tag:         v1.8.0
    SHA:         5cc935f7
    Built:
    Go version:  go1.22.7
    OS/Arch:     linux/amd64
    Enabled:     RBAC
erinish commented 1 week ago

I've run into this same issue and applied mostly the same patch for myself. Might be good to actually throw the PR together @Biodiscus else I feel like this is the kind of issue that doesn't get picked up because of how low priority it is. If there are some misgivings about color vibrancy it's probably easier to work out in a PR (though I'd argue that's the terminal's realm of responsibility).