xfs_scrub controller

[frezbo]

Feature Request

Implement a Talos controller for periodically running xfs_scrub. This also needs to be configurable by a machine configuration document.

References

• https://man7.org/linux/man-pages/man8/xfs_scrub.8.html
• https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/tree/scrub

[dsseng]

Perhaps it should be not only for XFS but flexible with possibilities to include e.g. btrfs we plan on adding, as it is also often used with a maintenance schedule in place. So I'd do a config format listing scrub configs for each FS type.

[smira]

If we want to make it simple, I would start with defaults and a feature flag which enables it (and we keep it disabled for now). Then, we look at all VolumeStatuses, find ones which are Ready, match on filesystem type, and schedule xfs_scrub accordingly from boot time

[frezbo]

If we want to make it simple, I would start with defaults and a feature flag which enables it (and we keep it disabled for now). Then, we look at all VolumeStatuses, find ones which are Ready, match on filesystem type, and schedule xfs_scrub accordingly from boot time

I think we'd still need the interval to be configurable, since this could potentially lockup writes to filesystem

[dsseng]

Yes, these operations might make system slow

[dsseng]

We should also note in the docs that xfs_scrub is considered an experimental program according to its docs