siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.9k stars 555 forks source link

feat: add parsing of vlanNNNN:ethX style VLAN cmdline args #9583

Closed jnohlgard closed 3 weeks ago

jnohlgard commented 3 weeks ago

What? (description)

Fixes #9552

Recognize the alternative form vlan=vlan1:eth1 for specifying VLANs on the kernel command line. Additionally adds a check for the vlan ID range. The created links will still use the format ethX.NNNN for the interface names, but at least this patch allows parsing both forms on the command line.

Why? (reasoning)

The Talos docs at https://www.talos.dev/v1.8/reference/kernel/#vlan refers to the dracut command line docs which describe two alternative formats for vlan=.

Acceptance

Please use the following checklist:

See make help for a description of the available targets.

smira commented 3 weeks ago

thank you!

DmitriyMV commented 3 weeks ago

/m