smira
commented
1 week ago That unknown entity is my personal signature which I suppose is expected. Let me know if there is something more you'd like me to do for this.
Thank you, it's all good we'll re-sign the commit and it should be all green.
Pull Request
What? (description)
This patch adds a file search name and a file path for the QEMU provisioner for Arch Linux systems.
Why? (reasoning)
tl;dr ArchLinux renamed the 4M BIOS file over a year ago and in the last week removed the fallback it was using instead.
ArchLinux recently stopped shipping 2M BIOS images which the ability to use the QEMU provisioner on the distro. The existence of the 2M images have been masking the inability to find the 4M versions.
Several years ago the package maintainer for Arch's evdk2 BIOS images renamed the files with a non-standard name. Since then tools using the search paths were accidentally falling back on the 2M images. This tool is one of the ones affected and this patch addresses the file name path and adds the standard search path for ArchLinux.
You can verify the destination of the various install paths.
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)I ran the conformance check, the only failure there is:
That unknown entity is my personal signature which I suppose is expected. Let me know if there is something more you'd like me to do for this.
I wasn't able to get the unit-tests working as I'm using podman/buildah on my local system not docker which doesn't support a few of the more exotic container patterns used in the unit-tests (I gave up when I got to the layer linking). I was able to generate a fresh talosctl binary from my branch which I'm using locally for now.