sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!
213 stars 46 forks source link

Support Query Params #12

Closed runemadsen closed 10 years ago

runemadsen commented 10 years ago

This pull request adds a slightly bigger feature: support of query params in the URL. I added tests and documentation, so it should pretty self-explanatory.

sideshowcoder commented 10 years ago

I like it, some comments about improving the code style so. I know much is the code I wrote initially just would love if it would be cleaner so some ideas here. Maybe there is a opportunity to not let it rot like it is ;)

runemadsen commented 10 years ago

Awesome! Yes, let's clean it up. I'll take a look when I have time today.

sideshowcoder commented 10 years ago

I will also have some time next week to work on it again. I think by now its worth it to invest some time to keep it moving forward, I see awesome changes coming :)

runemadsen commented 10 years ago

Okay, I've cleaned the code up quite a bit, so:

Feel free to change it, and let me know what you think.

sideshowcoder commented 10 years ago

I really like it :+1: this makes it much cleaner I think. I am gonna merge it update the documentation on the website. I also think it's time to release a new Version on npm.

Thanks for this.

runemadsen commented 10 years ago

Grrrreat :+1:

sideshowcoder commented 10 years ago

Aaaand it's on npm! ;)

runemadsen commented 10 years ago

Wohoo!