search

sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!
213 stars 46 forks source link

Wrong log output for files with query params #15

Closed sideshowcoder closed 10 years ago

sideshowcoder commented 10 years ago

When I start canned in the spec/test_responses folder and I request a file with query params I get the correct file served but the output in the log shows the wrong file. This is not that bad but really confusing when mocking services which rely heavily on query params.

wrong_log

runemadsen commented 10 years ago

Woops. I'll fix this.

sideshowcoder commented 10 years ago

actually it is kind of a problem which comes from my original logging implementation which does not output the filename tries to reconstruct it. But since we got an HTTP object now I guess it is worth injecting the filename on the way.