search

sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!
213 stars 46 forks source link

Create an API documentation page based on the files #16 #38

Closed peinguin closed 8 years ago

peinguin commented 10 years ago

Hello. My name is Sergei. I have an idea about issue#16. My code has few problems. But I want show it to you. I use swagger-ui. And not display's root folder, but can if need. If you like that idea - we may discuss next steps for improving it.

peinguin commented 10 years ago

Express has static. And also code with waterfall was be just own express realization.

peinguin commented 10 years ago

Variant with async

sideshowcoder commented 10 years ago

Thanks for that, I'm booked with work right now sorry about that, but I'm going to look at this tomorrow. Also maybe @mulderp is interested in looking over this?

sideshowcoder commented 10 years ago

Sorry it took me so long, I had a look through and I like it so far, would it be possible to add the swagger assets as a git submodule or something? How is swagger installed normally? I feel like including everything in the repo seems to be hard to keep up to date.

Besides some minor things like organising the functions in the correct files and adding some tests around the extension API I'm good with merging this :+1:

Thanks for all your work, would love to include this!

peinguin commented 10 years ago

In next swagger version API may change. Plus I do not know how to set api endpoint in git submodule case.

sideshowcoder commented 8 years ago

I don't feel comfortable including all of swagger in the repo, so I'm gonna close this for now if there is a better way I'm happy to add it.