sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!
213 stars 46 forks source link

Support windows for GET response matching #41

Closed sideshowcoder closed 9 years ago

sideshowcoder commented 9 years ago

Based on the work by @hungrydavid this allows to match GET parameters via the same mechanism as is used for the POST response body matching.

This finally allows for full windows support because ? and & are no longer required in the filenames to match the GET request Parameters.

@hungrydavid do you mind reviewing this?

runemadsen commented 9 years ago

Great news! :+1:

sideshowcoder commented 9 years ago

@runemadsen do you mind taking a look if this makes sense? Since I'm currently using query parameters encoded as JSON in the file I'm not completely sure about this.

davidmjadams commented 9 years ago

Sure, I'll take a look this afternoon. 

— Sent from Mailbox

On Sat, Nov 29, 2014 at 12:01 AM, Philipp Fehre notifications@github.com wrote:

Based on the work by @hungrydavid this allows to match GET parameters via the same mechanism as is used for the POST response body matching. This finally allows for full windows support because ? and & are no longer required in the filenames to match the GET request Parameters. @hungrydavid do you mind reviewing this? You can merge this Pull Request by running: git pull https://github.com/sideshowcoder/canned multiple-get-responses Or you can view, comment on it, or merge it online at: https://github.com/sideshowcoder/canned/pull/41 -- Commit Summary --

davidmjadams commented 9 years ago

Other than the couple of comments, all looks good. Just give me a shout when you want me to merge.

sideshowcoder commented 9 years ago

@hungrydavid thanks for the review, I'm gonna merge myself.