Closed sideshowcoder closed 9 years ago
Great news! :+1:
@runemadsen do you mind taking a look if this makes sense? Since I'm currently using query parameters encoded as JSON in the file I'm not completely sure about this.
Sure, I'll take a look this afternoon.
— Sent from Mailbox
On Sat, Nov 29, 2014 at 12:01 AM, Philipp Fehre notifications@github.com wrote:
Based on the work by @hungrydavid this allows to match GET parameters via the same mechanism as is used for the POST response body matching. This finally allows for full windows support because ? and & are no longer required in the filenames to match the GET request Parameters. @hungrydavid do you mind reviewing this? You can merge this Pull Request by running: git pull https://github.com/sideshowcoder/canned multiple-get-responses Or you can view, comment on it, or merge it online at: https://github.com/sideshowcoder/canned/pull/41 -- Commit Summary --
- support multiple GET responses per file
update README -- File Changes -- M README.md (22) M canned.js (22) M package.json (2) M spec/canned.spec.js (27) A spec/test_responses/_multiple_get_responses.get.json (9) -- Patch Links -- https://github.com/sideshowcoder/canned/pull/41.patch https://github.com/sideshowcoder/canned/pull/41.diff
Reply to this email directly or view it on GitHub: https://github.com/sideshowcoder/canned/pull/41
Other than the couple of comments, all looks good. Just give me a shout when you want me to merge.
@hungrydavid thanks for the review, I'm gonna merge myself.
Based on the work by @hungrydavid this allows to match GET parameters via the same mechanism as is used for the POST response body matching.
This finally allows for full windows support because ? and & are no longer required in the filenames to match the GET request Parameters.
@hungrydavid do you mind reviewing this?