search

sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!
213 stars 46 forks source link

this resolve issue #73 adding lodash as extra dependency, in order to… #77

Closed xdemocle closed 8 years ago

xdemocle commented 8 years ago

… use utility _.isMatch function to compare two param objects the passed one and the one inside the json file. Also forcing the params values to Strings

sideshowcoder commented 8 years ago

could you merge the test I created into your branch or copy it across somehow? If it passes I'm happy to merge :+1:

sideshowcoder commented 8 years ago

Oh and you can of course add yourself to the contributors in the README :)

xdemocle commented 8 years ago

sorry, I forgot to switch on branch: issue-73_param_matching_bug.. i'm working to repair it somehow

sideshowcoder commented 8 years ago

No worries just copy of the test if that is easier...

xdemocle commented 8 years ago

Ok, I close this pull request and gonna open another with other branch: issue-73_param_matching_bug