Fix 3 simple bugs - Githubissues

sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!

213 stars 46 forks source link

Closed git-jiby-me closed 8 years ago

git-jiby-me commented 8 years ago

The regex for matching request, was not considering arrays in the request JSON
For request with a request body, canned was checking content type to exactly match application/json, which is not good as browsers may sent charset as well with the content type.
For matching request and filters with more accuracy, we were converting the values of all keys in request to string before comparing, but this was being done wrong as it was creating string of Objects and arrays as well, which it shouldn’t

git-jiby-me commented 8 years ago

@sideshowcoder I forgot to create a new feature branch for this PR, but i guess that is ok, please review and let me know if you need any changes.

If you can release a revision in npm, with these fixes today, it would be really cool :100:

git-jiby-me commented 8 years ago

@sideshowcoder I am also working in something similar to https://github.com/sideshowcoder/canned/issues/56, but my requirement being more of like having a filter like

//! proxyRequest: http:domain.com/path/endpoint?queryKey=queryValue

which will basically proxy matching request to the url and then provide the response from the url back.

Would this be something interesting for you?

sideshowcoder commented 8 years ago

Yes such a change feature as proxy would be quite valuable! thank you :)

I will try to get out a new version to npm today :)

sideshowcoder commented 8 years ago

I added you as a collaborator on canned as you are already adding a bunch of features and fixes :)

git-jiby-me commented 8 years ago

@sideshowcoder cool, thanks, thats nice :+1:

sideshowcoder commented 8 years ago

out on npm.

git-jiby-me commented 8 years ago

@sideshowcoder thanks for the quick publish, much appreciated :+1: