search

sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!
213 stars 46 forks source link

remove unnecessary loop on selectResponse and add a line to the readme #95

Closed wadtech closed 7 years ago

wadtech commented 8 years ago

to explain how to send json request bodies successfully.

sideshowcoder commented 8 years ago

:+1: in general try to avoid comments as much as necessary, if you feel something is unclear create a function with a good name, comments tend to go out of date way to quickly.

wadtech commented 8 years ago

I'm actually usually a fan of more documentation, JS isn't always the easiest thing to read :-)

sideshowcoder commented 7 years ago

Sorry I didn't merge this before, it is merged now, I had to rebase so couldn't click the button but it is in master.