Canned crashes when using query string parameters

sideshowcoder / canned

Server to respond with fake API responses, by using a directory of files for finding out what to say!

213 stars 46 forks source link

Canned crashes when using query string parameters #98

Closed targoo closed 8 years ago

sideshowcoder commented 8 years ago

Thanks for looking into this, I think that might be fixed by #96 but I'll take a look later today when I merge in the other. In the meanwhile mind providing a test case int spec/... to make sure this does not break again / is fixed?

targoo commented 8 years ago

https://github.com/sideshowcoder/canned/pull/96 probably going to fix it. cool. I'll work on the spec.

sideshowcoder commented 8 years ago

If you like to try with current master it should work, would be awesome to get a test case for it so!

targoo commented 8 years ago

i have added two more tests and it's all working now on master.

Finished in 0.831 seconds 66 tests, 73 assertions, 0 failures, 0 skipped

I guess we are ready for 0.3.8 ;-)

sideshowcoder commented 8 years ago

👍

sideshowcoder commented 8 years ago

merge via c246508

sideshowcoder commented 8 years ago

Ok 0.3.8 is out :)