Total Value in wallet oscillates

sideswap-io / sideswapclient

GNU General Public License v3.0

36 stars 9 forks source link

Total Value in wallet oscillates #29

Closed starius closed 1 month ago

starius commented 7 months ago

L-BTC is the only asset in the wallet. There are 3302 satoshis of L-BTC. The total value of the wallet oscillates in the range 3300 to 3304 sats every few seconds. I guess it can be related to price movements, but they should not affect the total value measured in sats.

sideswap-io commented 7 months ago

Thank you for reporting. Issue has been resolved and new builds are available.

While the individual asset rows are correct, we calculated the total LBTC value of the portfolio from the USD amount. Rounding errors gave rise to slippage. We now sum the LBTC amounts and produce a USD amount.

starius commented 7 months ago

Thank you! It makes sense.

I suggest that for accounts having only USDt it makes sense to use the old procedure to avoid a similar problem in-reverse.

The latest release lacks signatures. Can you sign it, please?

sideswap-io commented 1 month ago

Fixed in latest release (1.6.0).