search

sidevesh / Luminance

A simple GTK application to control brightness of displays including external displays supporting DDC/CI
GNU General Public License v3.0
91 stars 4 forks source link

Using a build system #16

Open Tachi107 opened 1 year ago

Tachi107 commented 1 year ago

Hi, first of all nice job! I've been looking for a software like this for quite some time.

Would you be interested in switching from a custom build.sh script to a proper build system? I was thinking about submitting a patch that includes Meson build definitions.

This would make life way easier for downstream packagers. For instance, I was looking into packaging this for inclusion in Debian's main repositories, but without a "normal" build system the process is a bit more involved.

sidevesh commented 1 year ago

hey @Tachi107, that would be great! Thanks for taking charge of this, appreciate the help.

Tachi107 commented 1 year ago

Is there a reason why you include .c files instead of .h ones?

sidevesh commented 1 year ago

not really, coded something in C after a long time and forgot that you are supposed to have separate header files, include guards kept things sane so didn't really cause me any issues, do you see any major problems with not using header files here ?

Tachi107 commented 1 year ago

No, it was just odd

Il 18 luglio 2023 23:20:14 CEST, Swapnil Devesh @.***> ha scritto:

not really, coded something in C after a long time and forgot that you are supposed to have separate header files, include guards kept things sane so didn't really cause me any issues, do you see any major problems with not using header files here ?