sidevesh / Luminance

A simple GTK application to control brightness of displays including external displays supporting DDC/CI
GNU General Public License v3.0
91 stars 4 forks source link

Migrate to GTK4 #2

Closed sidevesh closed 2 months ago

rien333 commented 2 months ago

I thought this had been done when I saw the screenshot on the main page! But that's just a gtk3 Adwaita theme, I suppose.

Still, UI-wise, I figure that is roughly how it should end up looking.

sidevesh commented 2 months ago

Initial GTK4 version is available in gtk4 branch, facing some issues with it though that I am not able to resolve atm, would appreciate any help with these: -- When the app launches, before the window appears there is a split-second flash of a black rectangle around where the window will appear -- Menu button popover does not seem to get dismissed when clicking outside the window unlike other GTK4 apps despite setting autohide to true -- The scale slider seems to not work correctly when dragging on it

sidevesh commented 2 months ago

Some deprecation warnings related to css styling that should ideally be fixed before release but otherwise the GTK4 version is fully functional now, well except the above issues

sidevesh commented 1 month ago

GTK4 version is now live on Arch AUR and deb and rpm packages are available on Releases tab, would appreciate if someone using Ubuntu and Fedora / Redhat test out the updated deb and rpm packages and let me know if things are okay.