search

sidevesh / Luminance

A simple GTK application to control brightness of displays including external displays supporting DDC/CI
GNU General Public License v3.0
91 stars 4 forks source link

Ctrl+q should quit the application #23

Closed rien333 closed 2 months ago

rien333 commented 2 months ago

See the GNOME human interface guidelines on keyboard shortcuts: https://developer.gnome.org/hig/reference/keyboard.html

sidevesh commented 2 months ago

That's only if the app is implementing keyboard shortcuts, which in case of this app I currently don't have any plans to implement, this is not meant to be an app that the user uses for long to necessitate quick actions via shortcuts.

rien333 commented 2 months ago

That's only if the app is implementing keyboard shortcuts, which in case of this app I currently don't have any plans to implement

Fair.

this is not meant to be an app that the user uses for long to necessitate quick actions via shortcuts.

However, I do think this request is very much in line with this goal. Specifically, creating an intuitive keyboard shortcut to quit the app precisely facilitates "I want to perform this one simple action, and perform it quickly without much thought".

In fact, the only reason I opened this was because I was longer in Luminance than needed because my muscle memory did not achieve what I wanted to achieve.

rien333 commented 1 month ago

this is not meant to be an app that the user uses for long to necessitate quick actions via shortcuts.

What does "time spent in app" have to do with "needs keyboard shortcuts", btw? You seem to imply that the less time you spent in an app, the less likely you are going to need keyboard shortcuts. I don't really see the relationship, and in fact, I would argue the inverse holds true: you need shortcuts to minimize your time spent in an app.

I'm sorry for double posting, but I do think you should give this some more consideration if you are serious about submission to Gnome circle. Implementing ctrl+q is part of feeling like a Gnome app.

Good work on the GTK4 port, btw!