Move to meson

[liz-desartiges]

also move things that should be in header in header fix https://github.com/sidevesh/Luminance/issues/16

[liz-desartiges]

for now I don't install the .desktop and icons but the app build just fine

[liz-desartiges]

it does require https://github.com/ahshabbir/ddcbc-api/pull/2 to build

[liz-desartiges]

I'm not sure how to handle the udev rules, I'm new to meson

for now I haven't really looked at packaging, didn't figure out how deb generation works

from reading the archwiki I got this for the pkgbuild :

# Maintainer: Swapnil Devesh <me@sidevesh.com>

pkgname=luminance
_pkgname=Luminance
pkgver=1.1.0
pkgrel=1
pkgdesc="A simple GTK application to control brightness of displays including external displays supporting DDC/CI"
arch=('x86_64')
url="https://github.com/sidevesh/$_pkgname"
license=('GPL3')
makedepends=('meson' 'git')
depends=('glib2' 'gtk4' 'libadwaita' 'ddcutil')
provides=("$pkgname")
conflicts=("$pkgname")
source=("git+https://github.com/sidevesh/$_pkgname.git#tag=$pkgver" "git+https://github.com/ahshabbir/ddcbc-api.git")
sha256sums=('SKIP' 'SKIP')

prepare() {
  meson subprojects download --sourcedir="$srcdir/$_pkgname"
}

build() {
    arch-meson "$srcdir/$_pkgname" _build
    meson compile -C _build
}

package() {
  meson install -C _build --destdir "$pkgdir"
  install -Dm644 "$srcdir/$_pkgname/data/44-backlight-permissions.rules" "$pkgdir/usr/lib/udev/rules.d/44-backlight-permissions.rules"
}

[sidevesh]

Hey @liz-desartiges , first of all thanks for your work on the PR, really appreciate it! Its also amazing coincidence that I was also working on exactly this recently,

My goals were shifting to meson, and I also wanted to add separate application id and the devel icon and header bar style in the app in development like the first party Gnome apps do,

I see you have fixed out the C code a lot including the warnings during build, amazing work and sorry for my messy C code,

I have pushed my implementation to meson_build branch and you can check it out, I had also incorporated installing the files into the meson config which we will need to do,

and also the deb, rpm and maybe even arch packaging / push will need to be done, but neither of our branches are addressing that so will have to work on it once rest of the stuff is in place, but in the meantime the build_rpm.sh and build _deb.sh files will have to be updated atleast to first do the meson build and then copy files from the right build dir.

Let me know if you would prefer incorporating changes from my branch to yours and then we merge in your PR or if you would rather I incorporate changes from yout PR to mine, up to you :) and again thanks for the sizable contribution, PRs like yours makes me incredibly happy about OSS!

[liz-desartiges]

I spent way more time than I though I would on this, I don't mind if you take this pr and incorporate your changes to it

[liz-desartiges]

for deb I found that debhelper support meson I just haven't figured out how it works, and there is a rpm package for meson to build them, as for arch what I posted above should do the trick

[sidevesh]

Cool, I guess I will update the arch pkgbuild once these changes are ready and merged, would you be looking at deb and rpm building from meson or any other changes you want to add to this PR ?

[liz-desartiges]

No I don't think so packaging is not really up my alley

[liz-desartiges]

Oops meson rpm module was removed : https://mesonbuild.com/Release-notes-for-0-62-0.html#removal-of-the-rpm-module

[liz-desartiges]

The packaging rules for fedora and meson : https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/

[sidevesh]

@liz-desartiges can you separate the C code changes including breaking things into header files into a separate PR that I can merge in first and then handle the meson setup ? I will tackle the rpm and deb packaging through meson after the C code fixes and and meson config for building and installing the app is merged into main branch.

[liz-desartiges]

I did both at the same time because I didn't know how to handle things without the separation between header and the rest -------- Original Message --------On 7/6/24 13:04, Swapnil Devesh wrote: @liz-desartiges can you separate the C code changes including breaking things into header files into a separate PR that I can merge in first and then handle the meson setup ? I will tackale the rpm and deb packaging through meson after the C code fixes and and meson config for building and installing the app is merged into main branch.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/sidevesh/Luminance/pull/29#issuecomment-2211739021", "url": "https://github.com/sidevesh/Luminance/pull/29#issuecomment-2211739021", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]