sidevesh / Luminance

A simple GTK application to control brightness of displays including external displays supporting DDC/CI
GNU General Public License v3.0
103 stars 6 forks source link

feat: add quit shortcut #35

Open rien333 opened 1 month ago

rien333 commented 1 month ago

This allows users to quit the application using Ctrl-q. Also see: #23.

As you pointed out correctly, the HIG doesn't enforce this shortcut, or at least not in case an application doesn't implement (other) shortcuts. However, I would still say that this way, the app feels more like a Gnome app, and fits better with the standard Gnome workflow. So, there's a pretty okay reason to implement this 🙂

Moreover, Luminance is an app that you don't need or want to stay in for a long time. This change facilitates that use case by allowing users to apply their muscle memory.

I understand not wanting to grow the codebase, but the change is fairly small.