search

sidewinderlabs / backplanejs

Other
12 stars 3 forks source link

Repeat's onDocumentReady() uses strict equality for unlike types of 'ordinal' attribute #79

Closed backplane-import closed 13 years ago

backplane-import commented 13 years ago

Imported from backplanejs Google Code issue 79.

Reporter fdintino
Date 20 Jul 2010 11:44:03 PM UTC

In Repeat.prototype.onDocumentReady(), the current ordinal is returned as a string (the type returned by getAttribute()) and an integer of the new ordinal value. If the ordinal values are the same, the equality still evaluates to false and setAttribute() is called unnecessarily.

Priority: Medium Type: Defect

backplane-import commented 13 years ago

Comment by fdintino on 20 Jul 2010 11:44:49 PM UTC

should read "...the current ordinal is compared as a string..."

backplane-import commented 13 years ago

Update by fdintino on 21 Jul 2010 12:02:41 AM UTC

Owner set to fdintino

backplane-import commented 13 years ago

Comment by markbirbeck on 21 Jul 2010 3:09:57 PM UTC

A fix is available at:

http://code.google.com/r/fdintino-backplanejs/source/detail?r=c5b20d63fd625ba93012864e0912a75e619b5820

Updates

Ticket status set to FixPending

Module: XForms Component: Ui

backplane-import commented 13 years ago

Comment by fdintino on 21 Jul 2010 3:47:31 PM UTC

This issue was closed by revision 4f4fc12d646330b6490f6a5d4b6a0e39d5df25c1 (originally 47a08c32a2).

Updates

Ticket status set to Fixed