The slider can be dragged to "10" which shouldn't exist and will cause the game to crash (There is no "program not responding" message, but the loading progress bar stops at the point where it is about to be completed.)

realomg commented 2 weeks ago

sidit77 commented 2 weeks ago

This is intentional. The correct maximum mipmap setting depends on the resolution of the used textures. However, resourcepacks can freely mix resolutions and correctly handling this fact would require basically a complete rewrite of how Minecraft handles textures. As a result there's really no easy way to determine the correct mipmap settings automatically. So I decided to make it the users responsibility to pick a sensible value. This is why there's a table with suggestions in the mod description. In practical terms, 9 should be the highest sensible value but if anyone wants to run a 1024x resourcepack with this mod they should be able to try without having to fork this mod.

tl;dr just don't set it to 10

realomg commented 2 weeks ago

OK, thank you, I have no more questions.

sidit77 / better-mipmaps

The slider can be dragged to "10" which shouldn't exist and will cause the game to crash (There is no "program not responding" message, but the loading progress bar stops at the point where it is about to be completed.) #9