search

sidlatau / flutter_email_sender

Allows send emails from flutter using native platform functionality.
Apache License 2.0
146 stars 81 forks source link

iOS - Added Privacy Manifest #108

Closed martin-headspace closed 3 months ago

martin-headspace commented 3 months ago

Summary

Added an empty Privacy Manifest to the iOS project in preparation for the May 1st Deadline for 3rd Party SDKs that include native iOS code.

Description

Starting May 1: You’ll need to include approved reasons for the listed APIs used by your app’s code to upload a new or updated app to App Store Connect. ... Make sure to use a version of the SDK that includes its privacy manifest and note that signatures are also required when the SDK is added as a binary dependency.

Privacy updates for App Store submissions - Latest News - Apple Developer Upcoming third-party SDK requirements - Support - Apple Developer

Impact and Testing

Developers using an updated version of this library on their iOS projects shouldn't see any issues related to the Privacy Manifest

Contributor Note

Based on the language on Apple's Website, this change seems to be mandatory for all 3rd Party Libraries. The impact of not adding it is unclear to me, but hopefully having it will be better than not.

sidlatau commented 3 months ago

Thanks for the PR! But I am not sure if it is needed. Did you get any warnings related to this library when submitting the app?

martin-headspace commented 3 months ago

Hey @sidlatau , I haven't received any warnings.

Having said that, I'm following the same philosophy that the flutter team followed on https://github.com/flutter/packages/pull/5846 where it feels like the current list of mandatory plugins was selected arbitrarily, and eventually could grow to use other popular packages (like yours. btw thanks for maintaining it!)

I believe this is specially important given that lacking this manifest may eventually cause problems for updating or releasing new apps to the App Store.

martin-headspace commented 3 months ago

You can find other projects that were not listed on the Apple News article but have prepared by adding their Privacy Manifests to their packages:

sidlatau commented 3 months ago

Tkanks for the provided details!