search

sidmohite / kNe-inference

A Bayesian inference framework to constrain kilonovae models
MIT License
0 stars 0 forks source link

Add extinction #2

Open dlakaplan opened 4 years ago

sidmohite commented 4 years ago

@dlakaplan Thinking more about this, it seems it would be computationally better if I include this at the data ingestion stage. Essentially, subtracting the extinction value from the limiting mags. I figured this would save the cost of having to do the addition of the value for every model draw : (lim_mag - extinction) same as (m_apparent + extinction). Thoughts on whether this would be equivalent?

dlakaplan commented 4 years ago

One thing to consider is that this is position (field)-dependent. So on the ingest stage you would need a different copy of the data for each field

sidmohite commented 4 years ago

Yes that's a good point. That should be manageable though. Okay so I will assume that there is an extinction value for each field.