search

sidoh / stockpile

ComputerCraft program to auto-stock craftable items in an AppliedEnergistics network
MIT License
8 stars 7 forks source link

Stockpile stops watching #2

Open midorlo opened 8 years ago

midorlo commented 8 years ago

Scenario:

Have a minimal AE2 system, Adv. Computer running stockpile. Setup a few stocks and watch your system doing okay. Retrieve your items a few times, bringing the stock under the defined margin (ex. 0 of 64 workbenches). Watch stockpile queuing the new workbenches and repeat 1-2 times. Watch stockpile doing nothing now. Hit CTRL+R to reload it and watch how it immediately queues the missing workbench stock. Repeatable with unmodified FTB Infinity 2.5.0.

sidoh commented 8 years ago

I've not been playing for several months, so I probably won't be able to debug this myself. Relevant code is here:

https://github.com/sidoh/stockpile/blob/master/stockpile/craftingRequester#L31

If I had to guess, I'd say there's something weird with the AE events. After stockpile requests a crafting job, it won't request it again until it gets an event from AE signaling that the relevant crafting job has completed.

You could update the log method to print out the message. I think this would make debugging a little easier.

https://github.com/sidoh/stockpile/blob/master/stockpile/craftingRequester#L62

If you end up finding the issue, I'd be happy to look at a PR. :)

sidoh commented 8 years ago

I've been playing again, and I think one problem is that the requests it makes aren't robust to the case where there are no crafting CPUs available. Basically stockpile requests the item, and has no idea whether or not the request was successfully received by AE. This is resolvable, but the CC AE2 API doesn't make it easy. It was easier to just build a bunch of crafting CPUs.

If I'm feeling motivated later on I can look into fixing this. Also happy to take a look at a PR.