Open edgarsi opened 1 year ago
To be frank, it isn't clear to me what the purpose of storeAsString
is:
x
to be stringified without data loss, e.g. int64 identifiers for UI output. This was my concern.If json-bigint
is used as a drop-in replacement for parsing all jsons, it is safe to say we don't want to convert to string
in cases where it isn't necessary, as it may break components expecting non-string
types. There are several questionable cases:
json-bigint
even used?json-bigint
claim "No integer part will ever be damaged by parsing". I don't know any use case for such numbers though, and have heard an opinion that non-integers should always be safe to round.number
, including large integers. I am not changing that, though I disagree with the choice.
Losing precision after the decimal point is almost always a non-issue. Using 'string' in such cases is usually worse.