search

sidorares / node-mysql2

:zap: fast mysqljs/mysql compatible mysql driver for node.js
https://sidorares.github.io/node-mysql2/
MIT License
3.95k stars 592 forks source link

misc changest #2594

Closed KunZhou-at closed 4 weeks ago

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.40%. Comparing base (cf3fa60) to head (4f26387). Report is 8 commits behind head on master.

Files Patch % Lines
lib/connection.js 77.77% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2594 +/- ## ========================================== + Coverage 90.32% 90.40% +0.08% ========================================== Files 71 71 Lines 15717 15716 -1 Branches 1333 1333 ========================================== + Hits 14196 14208 +12 + Misses 1521 1508 -13 ``` | [Flag](https://app.codecov.io/gh/sidorares/node-mysql2/pull/2594/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Sidorov) | Coverage Δ | | |---|---|---| | [compression-0](https://app.codecov.io/gh/sidorares/node-mysql2/pull/2594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Sidorov) | `90.40% <93.93%> (+0.08%)` | :arrow_up: | | [compression-1](https://app.codecov.io/gh/sidorares/node-mysql2/pull/2594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Sidorov) | `90.40% <93.93%> (+0.08%)` | :arrow_up: | | [tls-0](https://app.codecov.io/gh/sidorares/node-mysql2/pull/2594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Sidorov) | `89.94% <81.81%> (+0.10%)` | :arrow_up: | | [tls-1](https://app.codecov.io/gh/sidorares/node-mysql2/pull/2594/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Sidorov) | `90.22% <93.93%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrey+Sidorov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wellwelwel commented 4 weeks ago

Thanks @KunZhou-at. Is this PR an union of the following PRs?

If so, I suggest keeping the focus on them in order to better discuss and generate the changelogs when releasing them 🙋🏻‍♂️

However, it's interesting to know that they all ran 100% in the current tests 🚀

wellwelwel commented 4 weeks ago

I've replied to each of the PRs mentioned, I'll close this to focus the discussion on them 🙋🏻‍♂️

Please let me know if I'm misjudging this 🤝