chore(*): move to let/const

[SimonSchick]

IMPORTANT: VIEW WITHOUT WHITESPACE CHANGES

This does a few things: 1) Convert all usage of var to let/const 2) Beef up eslint rules to ensure the proper implementation of the former 3) Enabled strict mode (has to do with iteration in for in loops) 4) Remove dead code 5) Fixed some broken code (see REVIEW comments). 6) Emit some warn events when also logging to console.

Please note that tests are failing right now, I noticed a dead loop inside of a test that I fixed, please see the build log for explanation.

[SimonSchick]

Please note that the diff is particularly huge due to husky auto applying prettier and changing indents, not sure why this hit me in particular.

Some files, especially the benchmark files, cause huge diffs.

[SimonSchick]

Please also note that I only enabled lint rules that I deemed necessary, primarily finding unused and undefined references and definition order.

[SimonSchick]

If this PR is too big I can break it down into multiple chunks (per folder).

[sidorares]

looks like there are some real test failures, not just lint or something. Have you tried investigating them @SimonSchick ? Do you need any help?

[SimonSchick]

@sidorares as described I added at least 1 test failure which is caused by a loop I 'fixed'. Tbh the test output is kinda hard to read (since all sorts of non failures as logged as well) but I'm getting pretty much all of the same failures as https://travis-ci.org/sidorares/node-mysql2/jobs/424179988 does.

[sidorares]

I'll try to read more carefully your comments later today or tomorrow. We need to fix code or tests before merging

[SimonSchick]

Fixed the test-auth-switch test failure, I accidently removed a marker read when removing unused variables, restored that now.

[SimonSchick]

ping

[SimonSchick]

@sidorares hi

[SimonSchick]

poke

[sidorares]

hi @SimonSchick sorry, terribly busy last few weeks

we need to fix failing tests / conflicts to be able to merge. CI is still failing

[SimonSchick]

I specifically asked you to look at the the failing test case as the test that is failing right now was previously not even running. I will resolve the conflicts once CI passes :)

[SimonSchick]

On another note, is there a reason you execute nvm ls-remote in travis? Seems to serve no purpose but slow down builds.

[sidorares]

On another note, is there a reason you execute nvm ls-remote in travis? Seems to serve no purpose but slow down builds.

we can remove that, was trying to debug node version issue long time ago

[SimonSchick]

Rebased and removed the redundant version printing.

[SimonSchick]

Hey @sidorares had any time to look at that failing test? Otherwise I will comment out the failing test.

[SimonSchick]

Rebased again, can you please look into this?

[sidorares]

hi @SimonSchick I fixed the test but did something that caused my repo in a state GH can't create pull request for continuation of your commit. Could you cherry-pick 18bafedd5aac88aa06214da8478c2736b98daf16 and 54ef9dc7a595d4e7b38fe48b224137c75da41491 from my remote into your branch and we'll use this PR?

[SimonSchick]

done

[sidorares]

looks my issues were related to GH outage today. I'll try to re-trigger CI now

[sidorares]

looks my issues were related to GH outage today. I'll try to re-trigger CI now

[SimonSchick]

done

[SimonSchick]

Sorry for the comment spam, the outage was/is pretty bad lol.

[SimonSchick]

I added your changed but reworded the commits (force push), doesn't seem like they are showing up correctly tho.

[SimonSchick]

Hey @sidorares you might have to re-trigger these builds manually :)

[SimonSchick]

It's working! 😄

[sidorares]

Huh, finally it's there. Thanks for your work @SimonSchick and sorry it took so long time, last month was super busy for me