sidorares / node-rfb2

rfb wire protocol client and server
MIT License
138 stars 27 forks source link

updateClipboard Length U32, not 16 #17

Closed untoldone closed 8 years ago

untoldone commented 8 years ago

see page 26 of https://www.realvnc.com/docs/rfbproto.pdf

sidorares commented 8 years ago

hm, I'm pretty sure I tested this, I'll need to double check with spec - probably u16 still worked with < 65535 length

sidorares commented 8 years ago

thanks @untoldone , sorry it took so much time to have a look. There was almost identical pr today #19 which also fixed another typo, so I'm closing this one but thanks anyway! ( maybe your pr helped @yomr ? )

yomr commented 8 years ago

@untoldone @sidorares
Yes. The error I fixed started flushing the event, but @untoldone's bug fix, actually got the content to clipboard. Thanks @untoldone 👍