search

sidorares / react-x11

React renderer with X11 as a target
MIT License
239 stars 22 forks source link

reuse code from mylittledom #10

Open sidorares opened 7 years ago

sidorares commented 7 years ago

style implementation might be possible to completely reuse - https://github.com/manaflair/mylittledom/tree/master/sources/core/style

maybe some other parts

tagging @arcanis in hope to get some attention :)

arcanis commented 7 years ago

I think most of what's in the core folder could be reused, since they aren't really tied to the terminal part of mylittledom - the only thing that comes into my mind is the forwardToTextLayout trigger, which probably doesn't make as much sense with x11 (or maybe it does?).

The main thing I'm a bit concerned about is that I still plan some refactoring of this code (especially the styles), since I think I made the code a bit more complex than it should be (I tried to replicate classes, and by doing so I made some questionable choices that probably hinder the perfs).

sidorares commented 7 years ago

Thanks for having a look @arcanis

which probably doesn't make as much sense with x11 (or maybe it does?).

There is currently no text layout built in at all ( just canvas-like api fillText/measureText ) but I hope to add some kind of text layout manager using freebidi / harfbuzz , maybe also use yoga-layout with words as flex-wrap items

The main thing I'm a bit concerned about is that I still plan some refactoring of this code (especially the styles), since I think I made the code a bit more complex than it should be (I tried to replicate classes, and by doing so I made some questionable choices that probably hinder the perfs).

That's totally fine, I don't expect start adding styles and "minidom" components very soon, so you just keep in mind there are other projects that might want to factor out some of your functionality some time later