search

sidvishnoi / facebook-crap-remover

Chrome extension to hide unwanted posts based on keywords from your news feed.
3 stars 1 forks source link

web Accessible Resources #1

Closed mskian closed 5 years ago

mskian commented 5 years ago

I found this on manifest.json

"web_accessible_resources": [
    "inject.js"
  ]

why we need this ? there is no inject.js file

sidvishnoi commented 5 years ago

Good catch. I added inject.js earlier and later forgot to remove it from manifest. Harmless though. Feel free to send a PR, I don't really maintain this project.

mskian commented 5 years ago

Sure I will Send

I Spot this error too Uncaught Error: Extension context invalidated. Error Highlighter was point this line from the file extension.js

chrome.storage.local.get({ count: 0 }, res => {

After adding this Below Function not getting this error

if(typeof chrome.app.isInstalled!=='undefined'){
        chrome.storage.local.get({ count: 0 }, res => {
          chrome.storage.local.set({ count: res.count + 1 });
        });
       }
mskian commented 5 years ago

@sidvishnoi any idea about the errors I mentioned above

sidvishnoi commented 5 years ago

Not yet. I'll have to check it. I can't reproduce it locally though.

mskian commented 5 years ago

hm Login Facebook use it Max 5 to 10 mins after that log out it and goto extension page and check it I am not getting this continuously but sometimes I spot this https://stackoverflow.com/questions/53939205/how-to-avoid-extension-context-invalidated-errors-when-messaging-after-an-exte

mskian commented 5 years ago

It removes the non-registered Keywords too

example:

if I provide word got on the keyword section for hiding the post which having the word got but it hides the sentence with having the word got example post with the word the gotify

sidvishnoi commented 5 years ago

Looks like I would revert https://github.com/sidvishnoi/facebook-crap-remover/commit/52d46f887bea9c6be4197b6d5258c9faa5292c14. (It was working fine for my usage, and I tried to keep it really simple. It was 20min-30min work) Thanks for reporting. Feels good when someone else is also using your stuff 😅

mskian commented 5 years ago

@sidvishnoi Thanks for the Update bro :100: