Lists - Githubissues

trshemanske commented 2 months ago

First edits on ol and dl tags. ul and li have some content already.

siefkenj commented 2 months ago

This PR seems to include changes from #86 . Do you just want to close #86 and keep this one?

trshemanske commented 2 months ago

The content of a in a <dl><li> does not get an automatic period at the end. Whether in the example the title element should be followed by a colon or not is a bit ambiguous. In normal text, a colon follows a complete sentence, not an incomplete one. However, in this case the title <em>is</em> the marker for the list item, and typically has some punctuation following it. I tried without and it looks incomplete. I shall put the colons in unless you reply quickly enough ;-)</p> <p>As to the PR, it seems that when I checked out the branch for lists, I was still on the sage branch, so it seems that content got pulled in as well. I'll cancel the other one.</p> <p>Tom</p> <p>On Mon, Sep 2, 2024 at 11:15 AM Jason Siefken <strong><em>@</em></strong>.***> wrote:</p> <blockquote> <h2><strong><em>@</em></strong>.**** commented on this pull request.</h2> <p>In packages/docs/pages/reference/elements/dl.mdx <a href="https://github.com/siefkenj/pretext-book/pull/87#discussion_r1740171835">https://github.com/siefkenj/pretext-book/pull/87#discussion_r1740171835</a>:</p> <blockquote> <p>\ No newline at end of file</p> <ul> <li> <pre><code class="language-ptx-example"> +<FRAGMENT parents="p"> +<dl></code></pre> </li> <li> <li> </li> <li> <title>Groups of order 4:

Is it best practices to include the colon or omit it? Does the content of the tag get an automatic . after it like the title of a theorem?</h2> <p>In packages/docs/pages/reference/elements/ol.mdx <a href="https://github.com/siefkenj/pretext-book/pull/87#discussion_r1741055346">https://github.com/siefkenj/pretext-book/pull/87#discussion_r1741055346</a>:</p> <blockquote> <p>@@ -8,12 +8,64 @@ import {</p> </blockquote> <h1><code><ol></code></h1> <p>-Short description of what the <code><ol></code> tag does. +The <code><ol></code> tag renders an ordered list with default markers which can (if +desired) be modified. For comparison, see <a href="./ul"><code><ul></code></a>.</p> <h2>Syntax</h2> <SyntaxDisplay name="ol" /> <p>It would be good to list all the possibilities for marker. This can be done by changing this line to</p> <p><SyntaxDisplay name="ol" defaultVariant="Ol" additionalAttributeInfo={{ Ol: { marker: { value: "(1) (A) (a) (I) (i)" } } }}/></p> <p>This also makes it so that the <ol> for a list in a paragraph is the default that shows, rather than the <ol> exercises.</p> <p>— Reply to this email directly, view it on GitHub <a href="https://github.com/siefkenj/pretext-book/pull/87#pullrequestreview-2274465650">https://github.com/siefkenj/pretext-book/pull/87#pullrequestreview-2274465650</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/ANHA5DDMIVRVC4BQUPDEVKDZUR6HPAVCNFSM6AAAAABNGXHSKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZUGQ3DKNRVGA">https://github.com/notifications/unsubscribe-auth/ANHA5DDMIVRVC4BQUPDEVKDZUR6HPAVCNFSM6AAAAABNGXHSKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZUGQ3DKNRVGA</a> . You are receiving this because you authored the thread.Message ID: <strong><em>@</em></strong>.***></p> </blockquote> <p>-- Thomas R. Shemanske Grantham, NH</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

siefkenj / pretext-book

Lists #87