siefkenj / pretext-react

A ReactJS version of the Pretext UI
GNU General Public License v3.0
3 stars 7 forks source link

Sage Cells #1

Closed rbeezer closed 2 years ago

rbeezer commented 2 years ago
siefkenj commented 2 years ago
  • Seems every Sage Cell is getting extra indentation. See a simple one right before Example 4.2 of sample article. Second line has about 30 extra spaces before the code.

This is due to me having reformatted the HTML of that page specifically. It can be safely ignored.

  • Sage Cell in Section 3 should follow "As a reader..." - using a different language ("R") so may have a different class.

I've added a check for sage-r (in addition to my check for sage-cell and sage-practice. Are there any other classes I should look out for?

  • Example 4.2 is a torture-test of sorts. Fix indentations, and the variable a is not remembered in a subsequent cell. Neither is c, before and after the knowl.

It appears I didn't understand the link property on the sage cells correctly. I've posted on the embedded_sagecell.js Github to see if they have a workaround for the way I am setting up the cells. :-).

rbeezer commented 2 years ago

It can be safely ignored.

Good!

Are there any other classes

A bunch of them. Search pretext-html.xsl for the string 2016-06-13 and you will see them all. Sage Cells have needed some refactoring for a long time. I've never been too happy with how they are configured (and there have not been any improvements).

I've posted on the embedded_sagecell.js Github

sage-cell Group is a great place for this, too. Mention PreTeXt - our UTMOST grant helps support maintenance.

siefkenj commented 2 years ago

This should all be working now.