search

siege-media / contrast-ratio

A tool to calculate the contrast ratio between any two valid CSS colors.
https://www.siegemedia.com/contrast-ratio
MIT License
2.45k stars 221 forks source link

Responsive layout for contrast-ratio #12

Closed lifeofmle closed 8 years ago

lifeofmle commented 8 years ago

Created a responsive layout for the contrast ratio

I used SCSS to generate the CSS so that it was easier to see use the breakpoints

If you have any suggestions on the proposed changes, please let me know

LeaVerou commented 8 years ago

Hello there! Thanks for contributing! However, this is not really a PR for making the layout responsive. It’s a PR for adding all the tools you’ve learned to depend on for a project AND made the layout responsive. I do want to merge a PR for making the layout responsive, but I don’t want to overcomplicate a tiny app with tools that it doesn’t really need. Also, regarding the responsiveness, you have changed the way the layout behaves on larger screens too, so it's not just making it responsive, it’s also a redesign (and I really prefer how the instructions look now for larger screens). Also, you're still making changes to the PR branch, so if I merge this it will say "based on a work by Lea Verou" on my repo too!

Anyhow, I obviously can't merge this PR in this state, but I would welcome a smaller PR for making the layout responsive. I hope this doesn't discourage you from future contributions!

lifeofmle commented 8 years ago

Thanks for that explanation. I see and agree with your point of view and I'll try to do something simpler as a future contribution.