search

siegelaaron94 / atom-build-cmake

Generate and build cmake projects from within Atom.
MIT License
6 stars 12 forks source link

Fix for cmake generators extraction regex #47

Open NeiRo21 opened 4 years ago

NeiRo21 commented 4 years ago

Fixes #43

nitanmarcel commented 4 years ago

It also matches the asterix (*) from Unix Makefiles in the regex https://regex101.com/r/SpvsWB/1/

NeiRo21 commented 4 years ago

Yes, it marks the platform's default generator. The regex is still to be fixed for the case of two-line generator description.

On Sun, 29 Dec 2019, 16:16 nitanmarcel, notifications@github.com wrote:

It also matches the asterix (*) from Unix Makefiles in the regex https://regex101.com/r/SpvsWB/1/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/siegelaaron94/atom-build-cmake/pull/47?email_source=notifications&email_token=ABRDMDJCURW5YAYMWKO2A2DQ3DENVA5CNFSM4KAT5OMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZC4SY#issuecomment-569519691, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRDMDL5CCZCGHXXPDASTG3Q3DENVANCNFSM4KAT5OMA .

Garcia6l20 commented 4 years ago

why not simply [\*\s]{3} for the fix and maybe an improvement later to handle the cmake provided default generator (which is not systematically the first one) ?

Garcia6l20 commented 4 years ago

The author seem beeing inactive for a while, maybe someone can create a build-cmake-v2 package ?

sumagnadas commented 4 years ago

@Garcia6l20 build-cmake-v2 is a good idea actually