search

siegelaaron94 / atom-build-cmake

Generate and build cmake projects from within Atom.
MIT License
6 stars 12 forks source link

Let the user configure more settings. #6

Closed assumptionsoup closed 8 years ago

assumptionsoup commented 8 years ago

I needed to change the default settings, so I added config settings for the generator, the cmake executable path, and a "build suffix" (a string appended to the source dir to determine the build dir). This is my first time with an atom package and I can't remember the last time I used javascript, so critique is welcome.

I should probably be flushing a cache somewhere when the user edits these settings. I don't think they get refreshed unless the user restarts atom. That was a bit more than I was ready to take on at the moment...

siegelaaron94 commented 8 years ago

Great work, thanks for the help and the fact that you ever used javascript is more than I have really ever done. And with flushing the cache the make-build provider I believe they have settings there that could be used as an example to compare what you have to.