siemanko / tensorflow-deepq

A deep Q learning demonstration using Google Tensorflow
MIT License
1.17k stars 295 forks source link

DoublePendulum notebook outdated #28

Closed lsqshr closed 8 years ago

lsqshr commented 8 years ago

In ./notebooks/DoublePendulumn.ipynb, when I run

try:
    simulate(d, fps=30, actions_per_simulation_second=1, speed=1.0, simulation_resultion=0.01)
except KeyboardInterrupt:
    print("Interrupted")

It complains

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-7-7b5361d33da5> in <module>()
      1 try:
----> 2     simulate(d, fps=30, actions_per_simulation_second=1, speed=1.0, simulation_resultion=0.01)
      3 except KeyboardInterrupt:
      4     print("Interrupted")

TypeError: simulate() got an unexpected keyword argument 'actions_per_simulation_second'

The current simulate(...) has an interface way different to what is being called here

def simulate(simulation,
             controller= None,
             fps=60,
             visualize_every=1,
             action_every=1,
             simulation_resolution=None,
             wait=False,
             disable_training=False,
             save_path=None):
siemanko commented 8 years ago

Hi David,

I am sorry I commit that example by mistake, it is not supported :( I did it long time ago and I do not remember what it was doing. Sorry I could not be more helpful.

Szymon