search

siemens / codeface

Codeface is a framework for analysing technical and social aspects of software development
siemens.github.io/codeface
GNU General Public License v2.0
67 stars 38 forks source link

Add "FeatureExpression" as commit dependency #27

Closed clhunsen closed 9 years ago

clhunsen commented 9 years ago

Until now, only the touched features have been stored as commit dependencies when using the feature[_file] tagging options. Now, the corresponding touched feature expressions are stored additionally.

Furthermore, add node.js, JetBrains and RStudio items to .gitignore.

wolfgangmauerer commented 9 years ago

Am 21/08/2015 um 14:36 schrieb Claus Hunsen:

Until now, only the touched features have been stored as commit dependencies when using the |feature[_file]| tagging options. Now, the corresponding touched feature expressions are stored additionally.

  • Adjust feature extraction and storage mechanisms to handle also feature expressions.
  • Adjust emittance of data to the DB for matching new method signatures (tuples!). Break the feature-related test suite temporarily.
  • Fix the feature-related tests accordingly.

Furthermore, add node.js, JetBrains and RStudio items to |.gitignore|.

thanks, merged!

Best regards, Wolfgang

    You can view, comment on, or merge this pull request online at:

https://github.com/siemens/codeface/pull/27

    Commit Summary

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27.

mitchell-joblin commented 9 years ago

On Fri, Aug 21, 2015, 23:18 Wolfgang Mauerer notifications@github.com wrote:

Am 21/08/2015 um 14:36 schrieb Claus Hunsen:

Until now, only the touched features have been stored as commit dependencies when using the |feature[_file]| tagging options. Now, the corresponding touched feature expressions are stored additionally.

  • Adjust feature extraction and storage mechanisms to handle also feature expressions.
  • Adjust emittance of data to the DB for matching new method signatures (tuples!). Break the feature-related test suite temporarily.
  • Fix the feature-related tests accordingly.

Furthermore, add node.js, JetBrains and RStudio items to |.gitignore|.

thanks, merged!

I saw that Travis ci is failing now. Didn't yet look into why. Did the test pass locally?

--Mitchell

Best regards, Wolfgang

You can view, comment on, or merge this pull request online at:

https://github.com/siemens/codeface/pull/27

Commit Summary

  • Update .gitignore with node.js, JetBrains and RStudio items
  • Fix feature-related tests
  • Add 'FeatureExpression' as commit dependency

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27.

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27#issuecomment-133565907.<img src=" https://ci4.googleusercontent.com/proxy/uVDP57DAlUAnim26Ad7ngwkTwOsLOB3xu6VlTRX1ktubPfAK_BHlR2tSavccMlF2FJ71k_UPTKLsUxCL6XlWLsFtzmRjnOTGa50cL8cKdRK5IjeqdASZHpLOImveQMvNseig3WGV6uawFlbhGaeCLIhmyxkSng=s0-d-e1-ft#https://github.com/notifications/beacon/AClOHJxsWgm7VEtpN8hYY-wQxc0asfSSks5op401gaJpZM4Fv2Xx.gif ">

wolfgangmauerer commented 9 years ago

Am 23/08/2015 um 12:44 schrieb mitchell-joblin:

On Fri, Aug 21, 2015, 23:18 Wolfgang Mauerer notifications@github.com wrote:

Am 21/08/2015 um 14:36 schrieb Claus Hunsen:

Until now, only the touched features have been stored as commit dependencies when using the |feature[_file]| tagging options. Now, the corresponding touched feature expressions are stored additionally.

  • Adjust feature extraction and storage mechanisms to handle also feature expressions.
  • Adjust emittance of data to the DB for matching new method signatures (tuples!). Break the feature-related test suite temporarily.
  • Fix the feature-related tests accordingly.

Furthermore, add node.js, JetBrains and RStudio items to |.gitignore|.

thanks, merged!

I saw that Travis ci is failing now. Didn't yet look into why. Did the test pass locally?

that is likely caused by a non-working R version in CI as Andreas Ringlstetter reported recently.

Best regards, Wolfgang

--Mitchell

Best regards, Wolfgang

You can view, comment on, or merge this pull request online at:

https://github.com/siemens/codeface/pull/27

Commit Summary

  • Update .gitignore with node.js, JetBrains and RStudio items
  • Fix feature-related tests
  • Add 'FeatureExpression' as commit dependency

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27.

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27#issuecomment-133565907.<img src=" https://ci4.googleusercontent.com/proxy/uVDP57DAlUAnim26Ad7ngwkTwOsLOB3xu6VlTRX1ktubPfAK_BHlR2tSavccMlF2FJ71k_UPTKLsUxCL6XlWLsFtzmRjnOTGa50cL8cKdRK5IjeqdASZHpLOImveQMvNseig3WGV6uawFlbhGaeCLIhmyxkSng=s0-d-e1-ft#https://github.com/notifications/beacon/AClOHJxsWgm7VEtpN8hYY-wQxc0asfSSks5op401gaJpZM4Fv2Xx.gif ">

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27#issuecomment-133814930.

mitchell-joblin commented 9 years ago

On Sun, Aug 23, 2015, 12:46 Wolfgang Mauerer notifications@github.com wrote:

Am 23/08/2015 um 12:44 schrieb mitchell-joblin:

On Fri, Aug 21, 2015, 23:18 Wolfgang Mauerer notifications@github.com wrote:

Am 21/08/2015 um 14:36 schrieb Claus Hunsen:

Until now, only the touched features have been stored as commit dependencies when using the |feature[_file]| tagging options. Now, the corresponding touched feature expressions are stored additionally.

  • Adjust feature extraction and storage mechanisms to handle also feature expressions.
  • Adjust emittance of data to the DB for matching new method signatures (tuples!). Break the feature-related test suite temporarily.
  • Fix the feature-related tests accordingly.

Furthermore, add node.js, JetBrains and RStudio items to |.gitignore|.

thanks, merged!

I saw that Travis ci is failing now. Didn't yet look into why. Did the test pass locally?

that is likely caused by a non-working R version in CI as Andreas Ringlstetter reported recently.

OK. Then we should fix that asap otherwise we again get into this situation where code is getting merged while unknowingly breaking things. Normally I don't merge until Travis ci passes on another branch.

Did the tests pass at least locally before merging?

--Mitchell

Best regards, Wolfgang

--Mitchell

Best regards, Wolfgang

You can view, comment on, or merge this pull request online at:

https://github.com/siemens/codeface/pull/27

Commit Summary

  • Update .gitignore with node.js, JetBrains and RStudio items
  • Fix feature-related tests
  • Add 'FeatureExpression' as commit dependency

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27.

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27#issuecomment-133565907.<img src="

https://ci4.googleusercontent.com/proxy/uVDP57DAlUAnim26Ad7ngwkTwOsLOB3xu6VlTRX1ktubPfAK_BHlR2tSavccMlF2FJ71k_UPTKLsUxCL6XlWLsFtzmRjnOTGa50cL8cKdRK5IjeqdASZHpLOImveQMvNseig3WGV6uawFlbhGaeCLIhmyxkSng=s0-d-e1-ft#https://github.com/notifications/beacon/AClOHJxsWgm7VEtpN8hYY-wQxc0asfSSks5op401gaJpZM4Fv2Xx.gif ">

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27#issuecomment-133814930.

— Reply to this email directly or view it on GitHub https://github.com/siemens/codeface/pull/27#issuecomment-133815790.<img src=" https://ci6.googleusercontent.com/proxy/5HIUIkJeuYt8mXyznDmtTUCSqnavZraqPlqpS6kc0t75rsDPUqPaWePovChBZaxY71wiLYhGVW6kwnLkGyjNGsTrTBR9TEbWD1nzVIdGAI6xcJAg0VotTqCoJ98tfJrevk0CwCBIHUI5fUokUw98PW1enKAPdQ=s0-d-e1-ft#https://github.com/notifications/beacon/AClOHNQXhIHXBTchJLSguFz_CDTcnv4fks5oqZwSgaJpZM4Fv2Xx.gif ">

Ext3h commented 9 years ago

Am 23.08.2015 um 12:46 schrieb Wolfgang Mauerer:

Am 23/08/2015 um 12:44 schrieb mitchell-joblin:

I saw that Travis ci is failing now. Didn't yet look into why. Did the test pass locally?

that is likely caused by a non-working R version in CI as Andreas Ringlstetter reported recently.

Best regards, Wolfgang I pinned the problem down. It's the biocLite.R script which isn't aware of R release 3.2.2. It is supposed to check for updates in that case, but apparently causes a runtime error in the corresponding codepath.

Locally I had to make biocLite.R aware of version 3.2.2 in order to make it pass.

Mailing list analysis is also broken with 3.2.2 as the package tm.plugin.mail isn't compatible yet either.

Greetings, Andreas

clhunsen commented 9 years ago

I saw that Travis ci is failing now. Didn't yet look into why. Did the test pass locally?

--Mitchell

All tests pass locally, otherwise, I wouldn't have opened the pull request. ;)