feat(debug): improved debug messages

[RufusJWB]

Motivation

Simplify debugging

Proposed Changes

Improving log messages

Test Plan

n/a

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[RufusJWB]

Thank you for the improvements suggested. Here are some requests for tweaking them.

All implemented. Thank you for the proposals

[DDvO]

@RufusJWB could you please squash you commits, while keeping the unrelated change to .gitignore in a separate commit, and rebase to handle the merge conflict (simply letting your changes override the recent change of -Wl,-rpath,= to -Wl,-rpath,. which has become also part of this PR).

[RufusJWB]

while keeping the unrelated change to .gitignore in a separate commit

Moved this to #61

[RufusJWB]

@RufusJWB could you please squash you commits,

done

[DDvO]

Please check the output of the CI test_all run:

make -f Makefile_tests test_Mock CMPCLIENT="./cmpClient" OPENSSL=openssl OPENSSL_VERSION=[DEBUG] LIB is set to header [DEBUG] OPENSSL_VERSION_MAJOR found in OPENSSLV_H [DEBUG] OS is not MacOS [TRACE] After OS check in header: OPENSSL_VERSION=3.0 [TRACE] OPENSSL_NUMBER_SEL=head -n 1 | sed -r 's/.*OpenSSL //' | awk '{print ($0+0)}' [TRACE] OPENSSLV_H=/usr/include/openssl/opensslv.h [TRACE] OPENSSL_VERSION=3.0 3.0
awk: fatal: cannot open file `[TRACE]' for reading: No such file or directory
make[1]: *** No rule to make target 'LIB'.  Stop.

Somehow the new diagnostic output confuses a Makefile used for the tests.

[RufusJWB]

Please check the output of the CI test_all run:

make -f Makefile_tests test_Mock CMPCLIENT="./cmpClient" OPENSSL=openssl OPENSSL_VERSION=[DEBUG] LIB is set to header [DEBUG] OPENSSL_VERSION_MAJOR found in OPENSSLV_H [DEBUG] OS is not MacOS [TRACE] After OS check in header: OPENSSL_VERSION=3.0 [TRACE] OPENSSL_NUMBER_SEL=head -n 1 | sed -r 's/.*OpenSSL //' | awk '{print ($0+0)}' [TRACE] OPENSSLV_H=/usr/include/openssl/opensslv.h [TRACE] OPENSSL_VERSION=3.0 3.0
awk: fatal: cannot open file `[TRACE]' for reading: No such file or directory
make[1]: *** No rule to make target 'LIB'.  Stop.

Somehow the new diagnostic output confuses a Makefile used for the tests.

looks good now

[DDvO]

Hmm, the test_all CI run still fails the same way. I suspect that also the output of OPENSSL_VERSION_MAJOR needs to be tweaked.

[DDvO]

BTW, would be nice not to have merge commits. Best practice is to use fixup commits (e.g., on the command line, git commit --fixup @).

[DDvO]

The CI still fails, supposedly because there is still one output line containing the string OPENSSL_VERSION: $(info [TRACE] After OS check in header: OPENSSL_VERSION=$(OPENSSL_VERSION))

[DDvO]

Argh, just recalled that this PR was still in trouble, and meanwhile I understand what went wrong: The new diagnostics output gets prepended to the version info expected by Makefile_v1.

Fixed by directing all the new diagnostic output to stderr. Also updated README.md

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud