siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.
https://ix.siemens.io/
MIT License
198 stars 67 forks source link

cannot deselect row in AG Grid in the top third of checkbox #1003

Closed varta5 closed 7 months ago

varta5 commented 10 months ago

What happened?

Hello Team!

In AG Grid a selected row cannot be deselected by right-clicking on the upper third part of the checkbox.

In dev tools I can see that the input field is smaller (16 x 9 px) than the ag-checkbox-input-wrapper div or the ag-checkbox div (both 16 x 16 px)

Same issue applies to the checkbox in the header row (if columnDefs contain headerCheckboxSelection: true)

Example code is the same as on in the iX docs:

https://ix.siemens.io/docs/grid/

example_checkbox_ag_grid01

example_checkbox_ag_grid02

example_checkbox_ag_grid03

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v2.0.4

Code to produce this issue.

import { Component } from '@angular/core';
import { GridOptions } from 'ag-grid-community';

@Component({
  selector: 'app-example',
  template: `
    <ag-grid-angular
      style="height: 12rem; width: 100%"
      class="ag-theme-alpine-dark ag-theme-ix"
      [gridOptions]="gridOptions"
    ></ag-grid-angular>
  `,
})
export default class AGGrid {
  gridOptions = {
    columnDefs: [
      {
        field: 'type',
        headerName: 'Type',
        resizable: true,
        checkboxSelection: true,
      },
      {
        field: 'status',
        headerName: 'Status',
        resizable: true,
        sortable: true,
        filter: true,
      },
      { field: 'hwVersion', headerName: 'HW version', resizable: true },
    ],
    rowData: [
      {
        type: 'Equipment',
        status: 'Normal',
        hwVersion: '2.0',
        checked: false,
      },
      {
        type: 'Positioner',
        status: 'Maintenance',
        hwVersion: '1.0',
        checked: true,
      },
      {
        type: 'Pressure sensor',
        status: 'Unknown',
        hwVersion: 'N/A',
        checked: false,
      },
    ],
    rowSelection: 'multiple',
    suppressCellFocus: true,
    checkboxSelection: true,
  } as GridOptions;
}
varta5 commented 9 months ago

Hello @nuke-ellington! When is the next step expected for this issue?

varta5 commented 7 months ago

Hello @nuke-ellington and @robert-wettstaedt ! Does Pull Request 1067 resolve this Issue? Or is it for something else?

nuke-ellington commented 7 months ago

Hello @varta5, you are correct this should now be fixed (2.1.1). And sorry for the late reply!