siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.
https://ix.siemens.io/
MIT License
207 stars 68 forks source link

ix-button add alarm color options #1117

Closed KaiSoellch closed 8 months ago

KaiSoellch commented 9 months ago

Prerequisites

Suggestion / feature request

it would be a good idea to have a red button for e.g. actions to delete data

image

I have created a pen that will realise this, apart from it being an angular demo app, the changes only affect css https://stackblitz.com/edit/zhex5c?file=src%2Fapp%2Fbuttons.ts

but for correct documentation and possibilities, the alert variant should be included. Also in the base component like here https://github.com/siemens/ix/blob/main/packages/core/src/components/button/button.tsx#L13 and other references

KaiSoellch commented 9 months ago

if desired, i can also integrate this into the ix-button component and create a pull request

danielleroux commented 9 months ago

@KaiSoellch The requirement is already tracked in our internal backlog to provide more button variants [IX-364]

@silviowolf @kathrinschalber @linstedt Maybe you can give more insights here?

KaiSoellch commented 9 months ago

Here is some backstory on my needs within my application, which I am currently rewriting completely to only use ix components image

kathrinschalber commented 8 months ago

Hi @KaiSoellch and thanks for the example - as @danielleroux already pointed out, the red button you shared for user delete is already on our backlog for dangerous actions, including a filled, outline and ghost style similar to the primary button.

We also discussed the behavior for the warning button. Instead of introducing another button type, we suggest using the grey secondary button or the outline or ghost version of the danger button, depending on the use case, to ensure clarity for our users. Would this proposed solution align with your requirements?

KaiSoellch commented 8 months ago

hi @kathrinschalber thanks for your insights. these buttons are only for admins so i change them if your version of danger action buttons are available. in the meantime i will leave them as is.