Button inside shadow-root is not disabled - Githubissues

siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.

https://ix.siemens.io/

MIT License

174 stars 62 forks source link

Button inside shadow-root is not disabled #1259

Closed petrakristova closed 3 weeks ago

petrakristova commented 1 month ago

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?

If ix-button or ix-icon-button is disabled, button element inside shadow-root is enabled. I would expect it also to be disabled.

What type of frontend framework are you seeing the problem on?

Angular

Which version of iX do you use?

v2.2.1

Code to produce this issue.

<ix-button disabled class="m-1">Disabled button</ix-button>
<ix-icon-button icon="info" variant="Primary" disabled class="m-1"></ix-icon-button>

danielleroux commented 1 month ago

@petrakristova why do you expect this?

petrakristova commented 1 month ago

Because if assistive reader or test framework gets the button, it gives you false reading of the disabled state.