feat(vue): add v-model support to ix-select and ix-toggle

siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.

https://ix.siemens.io/

MIT License

174 stars 62 forks source link

feat(vue): add v-model support to ix-select and ix-toggle #1280

Closed tiagogviegas closed 6 days ago

tiagogviegas commented 1 month ago

💡 What is the current behavior?

IxSelect and IxToggle don't support v-model directive out of the box. Being components that often are used in form control v-model support should exist.

🆕 What is the new behavior?

Updated vueOutputTarget options to enable support for v-model binding in ix-select and ix-toggle.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

[ ] 🦮 Accessibility (a11y) features were implemented
[ ] 🗺️ Internationalization (i18n) - no hard coded strings
[ ] 📲 Responsiveness - components handle viewport changes and content overflow gracefully
[ ] 📄 Documentation was reviewed/updated (pnpm run docs)
[ ] 🧪 Unit tests were added/updated and pass (pnpm test)
[ ] 📸 Visual regression tests were added/updated and pass (Guide)
[x] 🧐 Static code analysis passes (pnpm lint)
[x] 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 239c7f55834565af1826e5598e53cada39224241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

| Name | Type | | ------------------- | ----- | | @siemens/ix | Minor | | @siemens/ix-vue | Minor | | @siemens/ix-aggrid | Patch | | @siemens/ix-angular | Minor | | @siemens/ix-react | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tiagogviegas commented 1 month ago

PR looks good but it might look even nicer if we could set up v-model support for all iX components ;-) Not sure how much effort this would be though..

Do we have a list of which components make sense to add v-model support? In my opinion it would only make sense to add it to components which have a 2-way data binding logic.

nuke-ellington commented 1 month ago

PR looks good but it might look even nicer if we could set up v-model support for all iX components ;-) Not sure how much effort this would be though..

Do we have a list of which components make sense to add v-model support? In my opinion it would only make sense to add it to components which have a 2-way data binding logic.

Unfortunately no. One would have to check all components manually.

danielleroux commented 6 days ago

We be implemented in https://github.com/siemens/ix/pull/1318

Also found an bug inside stencil vue output target which is patched in PR

https://github.com/siemens/ix/blob/14c8e1fa908c016893353eaf64744c61a8f1c2d9/patches/%40stencil__vue-output-target%400.8.8.patch#L7-L11

Close this one here