siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.
https://ix.siemens.io/
MIT License
174 stars 62 forks source link

fix(core/push-card): adjust colors and v3 adaptions #1317

Open matthiashader opened 2 weeks ago

matthiashader commented 2 weeks ago

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: #N/A, [IX-691], [IX-346]

๐Ÿ†• What is the new behavior?

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

๐Ÿ‘จโ€๐Ÿ’ป Help & support

changeset-bot[bot] commented 2 weeks ago

๐Ÿฆ‹ Changeset detected

Latest commit: 424f8b3ee6f94b01efa1b473f4bad99eecea8972

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------- | ----- | | @siemens/ix | Patch | | @siemens/ix-angular | Patch | | @siemens/ix-react | Patch | | @siemens/ix-vue | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 4 days ago

Report of strictNullChecks (strictPropertyInitialization) check

๐Ÿ˜ข Total errors increased in PR branch: 1

Increased errors in PR branch: src/components/push-card/push-card.tsx - 1 errors - src/components/push-card/push-card.tsx:33:11 ` Property 'notification' has no initializer and is not definitely assigned in the constructor.` - src/components/push-card/push-card.tsx:39:11 ` Property 'header' has no initializer and is not definitely assigned in the constructor.` - src/components/push-card/push-card.tsx:44:11 ` Property 'heading' has no initializer and is not definitely assigned in the constructor.` - src/components/push-card/push-card.tsx:49:11 ` Property 'subheading' has no initializer and is not definitely assigned in the constructor.` - src/components/push-card/push-card.tsx:69:11 ` Type '"std" | undefined' is not assignable to type 'TypographyColors'. Type 'undefined' is not assignable to type 'TypographyColors'.`