search

siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.
https://ix.siemens.io/
MIT License
197 stars 65 forks source link

fix(card-list): fixed card-list show all ellipsis issue #1354

Closed ridvandmrc closed 2 months ago

ridvandmrc commented 3 months ago

💡 What is the current behavior?

When the title of a card-list card becomes too long, the "Show all" - action is not completely visible anymore.

GitHub Issue Number: #1295

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

👨‍💻 Help & support

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: ce28b659b515d10a962ad7de178fc0f2aa51213d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------- | ----- | | @siemens/ix | Patch | | @siemens/ix-angular | Patch | | @siemens/ix-react | Patch | | @siemens/ix-vue | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ridvandmrc commented 3 months ago

It looks like: image

danielleroux commented 3 months ago

@ridvandmrc Thanks for PR

🧪 Unit tests were added/updated and pass (pnpm test) 📸 Visual regression tests were added/updated and pass (Guide) 🧐 Static code analysis passes (pnpm lint) 🏗️ Successful compilation (pnpm build, changes pushed)

You marked everythink as checked, but build does not work because of linting error also testcases are missing here. Is this PR still in draft?

ridvandmrc commented 3 months ago

@ridvandmrc Thanks for PR

🧪 Unit tests were added/updated and pass (pnpm test) 📸 Visual regression tests were added/updated and pass (Guide) 🧐 Static code analysis passes (pnpm lint) 🏗️ Successful compilation (pnpm build, changes pushed)

You marked everythink as checked, but build does not work because of linting error also testcases are missing here. Is this PR still in draft?

Yes it is still draft, give me a second to update

github-actions[bot] commented 3 months ago

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

Total errors are the same in both branches

ESLint check

Total ESLint warnings are the same in both branches

danielleroux commented 3 months ago

/snapshots:approve --args=card-list.e2e --sha=9774f4b002e7de4914c3406b1e82a41d475bb4cf