Docs/formwwriting update/review

siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.

https://ix.siemens.io/

MIT License

208 stars 67 forks source link

Docs/formwwriting update/review #1544

Closed tokyojen closed 3 weeks ago

tokyojen commented 3 weeks ago

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

-

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

[ ] 🦮 Accessibility (a11y) features were implemented
[ ] 🗺️ Internationalization (i18n) - no hard coded strings
[ ] 📲 Responsiveness - components handle viewport changes and content overflow gracefully
[x] 📄 Documentation was reviewed/updated (pnpm run docs)
[ ] 🧪 Unit tests were added/updated and pass (pnpm test)
[ ] 📸 Visual regression tests were added/updated and pass (Guide)
[ ] 🧐 Static code analysis passes (pnpm lint)
[ ] 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 97cad9e580c73b8716c881e3462ad0c22c787ca1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tokyojen commented 3 weeks ago

Please make the suggested changes. Note the removal of Oxford commas, the addition of full stops and the minimal punctuation approach.

github-actions[bot] commented 3 weeks ago

Report of `strict` check

src/components/select/select.tsx

src/components/select/select.tsx(466,37): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.: error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.