search

siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.
https://ix.siemens.io/
MIT License
198 stars 67 forks source link

menu avatar placeholder image missing #195

Closed nuke-ellington closed 1 year ago

nuke-ellington commented 1 year ago

I'm submitting a...


[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

The ix-menu-avatar has an empty grey circle without an illustration of an avatar.

image
danielleroux commented 1 year ago

@nuke-ellington I removed the patch label, because we must also provide a solution to add custom avatar images.

image
danielleroux commented 1 year ago

@nuke-ellington is this issue fixed with #201 or do we want to implement the feature to display an image with this issue?

nuke-ellington commented 1 year ago

@nuke-ellington is this issue fixed with #201 or do we want to implement the feature to display an image with this issue?

@danielleroux I think we might want to take this issue to JF once again and add the image later.

nuke-ellington commented 1 year ago

276

danielleroux commented 1 year ago

Outcome of JF. Implement first letter feature.

sn0wcat commented 1 year ago

IMHO the component should let the developer set up the image on his own, by just setting the link.

But, if we are already implementing some default behavior, we should probably use gravatar with fallback to two letter initials. This is what is being delivered by SiemensID in identity claim, and this will probably be the default Identity Provider for the large majority of applications which use iX.

Siemens ID delivers the gravatar image if one is configured, otherwise there is a two letter fallback to 

https://i0.wp.com/cdn.auth0.com/avatars/qu.png?ssl=1

Gravatar and Fallback Image:

image