siemens / ix

Siemens Industrial Experience is a design system for designers and developers, to consistently create the perfect digital experience for industrial software products.
https://ix.siemens.io/
MIT License
197 stars 65 forks source link

Display incorrect title when hover on navigation menu item #884

Closed angelinazhang9999990 closed 10 months ago

angelinazhang9999990 commented 11 months ago

What happened?

I'm using navigation menu as sidebar. While hovering on collapsed menu item, its title displayed as same as the icon name. However the expected title should be same as menu item's inner text.

Go to ix official document can also see the issue.

As the screenshots show, the title should be 'Normal Tab' instead of 'globe'

image

image

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v2.0.3

Code to produce this issue.

import { Component } from '@angular/core';

@Component({
  selector: 'app-example',
  template: `
    <ix-menu>
      <ix-menu-item home tab-icon="home"> Home </ix-menu-item>
      <ix-menu-item icon="globe"> Normal Tab </ix-menu-item>
      <ix-menu-item icon="star" disabled> Disabled Tab </ix-menu-item>
      <ix-menu-item icon="star"> With other Icon </ix-menu-item>
    </ix-menu>
  `,
})
export default class VerticalTabs {}
matthiashader commented 11 months ago

https://github.com/siemens/ix/pull/887 solves this issue